-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft support for reconstructing a probability distribution #428
Draft
garrison
wants to merge
15
commits into
main
Choose a base branch
from
reconstruct-distribution
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrison
added
enhancement
New feature or request
cutting
QPD-based circuit cutting code
labels
Oct 2, 2023
Pull Request Test Coverage Report for Build 9142521182Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses #259 by supporting reconstructing of probability distributions in the special case where the circuit does not separate into disconnected components.
I plan to maintain this as a fork until we figure out how it should integrate with the existing code. (There might be some refactoring that would be appropriate before we integrate it.)
Demonstration notebook here.
I expect coverage to fail because I have not added tests (there's only the notebook for now), but adding tests should be pretty straightforward.Remaining action items
_decompose_qpd_measurements
should throw an error ifcircuits
already has a register called"qpd_measurements"
README.rst
cut_wires
to be compatible with classical registers