Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cap writeBestDeterminants at largest C++ integer #50

Merged
merged 2 commits into from
Jan 21, 2025
Merged

cap writeBestDeterminants at largest C++ integer #50

merged 2 commits into from
Jan 21, 2025

Conversation

kevinsung
Copy link
Collaborator

No description provided.

caleb-johnson
caleb-johnson reviewed Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We should use ctypes.sizeof(ctypes.c_int) here to allow for larger # of determinants to be returned if architecture allows.

@caleb-johnson caleb-johnson merged commit 8fa61cd into Qiskit:main Jan 21, 2025
4 checks passed
@kevinsung kevinsung deleted the int-overflow branch January 21, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleb-johnson caleb-johnson caleb-johnson left review comments

@kvcmarshall6 kvcmarshall6 kvcmarshall6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinsung @caleb-johnson @kvcmarshall6