Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced One-liner Docstrings and Additional Documentation #960

Merged
merged 5 commits into from
May 30, 2024

Conversation

shubhusion
Copy link
Contributor

This pull request aims to improve the readability and usefulness of one-liner docstrings across the codebase. Additionally, it introduces new docstrings where they were missing or insufficient. These changes enhance the documentation quality, making the code more accessible and understandable.

@shubhusion
Copy link
Contributor Author

Hey @Roger-luo, I've submitted a PR addressing the enhancement of one-liner docstrings. Please review it and let me know if it aligns with your expectations. If there are any discrepancies or further adjustments needed, feel free to point them out. Your feedback will help me understand the project's standards better, guiding my future PRs.

Copy link
Member

@Roger-luo Roger-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good PR, but I notice you write docstring for class too. The docstring for class with method appear in the definition path of the builder does not need to be complicated (it's fine to be a one-liner for them). However, the methods appear in the builder path will need some examples as they will show up in the hint

src/bloqade/builder/parse/builder.py Outdated Show resolved Hide resolved
src/bloqade/builder/parse/builder.py Outdated Show resolved Hide resolved
src/bloqade/builder/parse/stream.py Outdated Show resolved Hide resolved
src/bloqade/builder/parse/trait.py Show resolved Hide resolved
src/bloqade/builder/parse/trait.py Outdated Show resolved Hide resolved
src/bloqade/builder/parse/trait.py Outdated Show resolved Hide resolved
@shubhusion
Copy link
Contributor Author

@Roger-luo please merge this PR. I have made the necessary changes

@Roger-luo
Copy link
Member

LGTM. According to #960, since this PR was made before the hackathon, I don't think unitary funds will count as a bounty in the system, and I'm sorry that I also wasn't aware of this, but I do really appreciate the effort here. I'm looking forward to your future PRs!

@Roger-luo Roger-luo merged commit 8de7ca8 into QuEraComputing:main May 30, 2024
5 of 8 checks passed
@shubhusion shubhusion deleted the shubhusion/issue946 branch May 30, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants