Improve docs on Batch tasks #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roger-luo
reviewed
May 30, 2024
Comment on lines
23
to
33
| - Created: The task has been created but not yet started. | ||
| - Running: The task is currently running. | ||
| - Completed: The task has completed successfully. | ||
| - Failed: The task has failed. | ||
| - Cancelled: The task has been cancelled. | ||
| - Executing: The task is currently being executed. | ||
| - Enqueued: The task is in the queue waiting to be executed. | ||
| - Accepted: The task has been accepted for execution. | ||
| - Unaccepted: The task has not been accepted for execution. | ||
| - Partial: The task has partially completed. | ||
| - Unsubmitted: The task has not been submitted for execution. |
There was a problem hiding this comment.
I don't think this is following the docstring format in #956
weinbe58
approved these changes
May 31, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
=======================================
Coverage 89.91% 89.91%
=======================================
Files 110 110
Lines 8129 8130 +1
=======================================
+ Hits 7309 7310 +1
Misses 820 820 ☔ View full report in Codecov by Sentry. |
|
This can be counted as a 16 USD bounty. Thank you for the contribution! |
|
@Roger-luo / @weinbe58 |
|
I will open separate issues for these merged PRs to make the bots work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #741