Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Performance Notebook #36

Merged
merged 12 commits into from
Dec 12, 2019
19 changes: 19 additions & 0 deletions .github/workflows/binder.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Binder

on: [push]

jobs:
build:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v1
- uses: actions/setup-python@v1
with:
python-version: 3.7
- run: |
python -m pip install --upgrade pip
pip install jupyter-repo2docker

- name: Test building with repo2docker
run: repo2docker --no-run .
13 changes: 10 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ For inspiration, see https://github.com/jakevdp/altair-transform
## Getting started

```sh
pip install ibis-vega-transform "tornado<6"
pip install ibis-vega-transform
jupyter labextension install ibis-vega-transform
```

Expand Down Expand Up @@ -53,10 +53,17 @@ phoila "examples/Charting Example.ipynb"
### Tracing

If you want to see traces of the interactiosn for debugging and performance analysis,
install tthe `jaeger-all-in-one` binary and the `jupyterlab-server-proxy-saulshanabrook`
install the `jaeger-all-in-one` binary and the `jupyterlab-server-proxy-saulshanabrook`
lab extension to see the Jaeger icon in the launcher.

TheJjaeger server won't actually be started until a HTTP request is sent to it,

```bash
conda install -c conda-forge
jupyter labextension install jupyterlab-server-proxy-saulshanabrook
```


The Jaeger server won't actually be started until a HTTP request is sent to it,
so before you run your visualization, click the "Jaeger" icon in the JupyterLab launcher or go to
`/jaeger` to open the UI. Then run your visualization and you should see the traces appear in Jaeger.

Expand Down
2 changes: 2 additions & 0 deletions binder/environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@ dependencies:
- python>=3.7
- jupyterlab
- notebook<6.0
- jaeger

3 changes: 1 addition & 2 deletions binder/postBuild
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ set -o xtrace
pip install -e .
jlpm install
jlpm run build
jupyter labextension install @jupyter-widgets/jupyterlab-manager --no-build
# jupyter labextension install jupyterlab-server-proxy-saulshanabrook --no-build
jupyter labextension install jupyterlab-server-proxy-saulshanabrook --no-build
jupyter labextension install . --no-build
jupyter lab build

5 changes: 3 additions & 2 deletions examples/Charting Example.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@
"conn = ibis.mapd.connect(\n",
" host='metis.mapd.com', user='mapd', password='HyperInteractive',\n",
" port=443, database='mapd', protocol= 'https'\n",
")\n",
"t = conn.table(\"flights_donotmodify\")"
")"
]
},
{
Expand Down Expand Up @@ -403,6 +402,8 @@
}
],
"source": [
"t = conn.table(\"flights_donotmodify\")\n",
"\n",
"states = alt.selection_multi(fields=['origin_state'])\n",
"airlines = alt.selection_multi(fields=['carrier_name'])\n",
"\n",
Expand Down
Loading