-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoC for Ragna meta package #439
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pmeier, I have tested this branch thoroughly building and installing wheels a number of times in fresh environments.
Installation and everything works all good.
However I noticed one thing that the version that is being checked in setup.py
looks locally something like 0.3.0.dev31+g7743725.d20240704
& say we've published ragna-base==0.3.0
on pip. Would it still be going to give error saying ERROR: Could not find a version that satisfies the requirement ragna==0.3.0.dev31+g7743725.d20240704
?
I also noticed that currently, it is essential to build Would we want to do the same on the CI workflow as well? (However more experimentation is yet to be done) |
I did some workaround on a branch on my fork with this one as the base. You can also download & test build artifacts from here: Currently, one cannot install |
I think the failure here can be used as a breaking point which should prevent us from going ahead to publish the meta-package until & unless pip has the access to the dependent |
This has nothing to do with
We'll never install
This is just a failing docker build, because I haven't updated the Dockerfile yet. Let me do that today.
Yes, of course. We'll only ever publish them together. The first release for both of them will be v0.3.0 assuming we can get this done by then. |
Sorry to ask again, I just want to confirm that when releasing & publishing wheels, For example v0.3.0, ragna would have
Right, that makes sense. But just to make a note again that installation of wheels will only pass either if ragna-base is already installed in the environment or that specific version of ragna-base could be found on Pypi. It's not an issue but a checkpoint type of a thing.
😬 I reffered to the another linked failure here on my fork, this is the one I refer to as checkpoint. |
I see where the confusion is coming from now. We are using Lines 1 to 6 in 9776ec5
Lines 67 to 70 in 9776ec5
It looks at the current state of git and produces a version number from it. So your string
You can check the version it produces with Long story short: since we'll add a git tag before each release, all the extra version information that we have during development will be gone.
I'm aware, but again this is not an issue. For development, we'll never install
I don't understand what you mean by "checkpoint". |
That makes sense, thanks a lot on confirming this.
I mean just a checkpoint to see corresponding This looks promising, Please do let me know if I can assist you with anything related 🚀 |
The failure means that the wheel cannot be build by the sdist, i.e. the sdist is broken. This needs to be fixed before moving forward. |
@arjxn-py If you are still eager to help with this, could you check why we cannot build a wheel from the sdist on this branch, i.e. find out what is broken with the sdist? From the error we get when running |
This is an alternative to #405. With this we have a new folder
meta-package
that contains apyproject.toml
and asetup.py
:pyproject.toml
is minimal version of the one we have in our project root. We should have a CI job that makes sure both are in sync.setup.py
does nothing but injects the optional dependencies andragna_base
as requirements for the meta package.Here is how you do a development install
To release you can do
I don't know why I explicitly need to set
--sdist --wheel
for the meta-package build. If I don't, the build errors. This seems to be a bug in thebuild
package. Will look into it.