Fix #504 : honor the indentation in the MetadataFilter formatting #510
Conversation
| self.current_chat["metadata"]["input"] | ||
| ) | ||
| ) | ||
| .replace("\n", "<br>") |
There was a problem hiding this comment.
Shouldn't we able to remove this given that <pre> should honor line breaks?
There was a problem hiding this comment.
That's indeed the first thing I have tried, but no.
<pre> does not natively honor line breaks. It can be done with CSS but then the line breaks at the first opportunity, and it doesn't result in a hierarchical result anymore.
| ) | ||
| ) | ||
| .replace("\n", "<br>") | ||
| .replace(" ", " ") |
There was a problem hiding this comment.
.replace("\n", "<br>")
We need to put explicit <br> to have line-breaks at the right places, as explained in the other comment.
.replace(" ", " ")
We need to replace the whitespaces as explicit non-breakable spaces to show indentation, otherwise it's ignored.
Try removing these lines to see how it behaves.
There was a problem hiding this comment.
So do we even need the <pre> tag in that case?
There was a problem hiding this comment.
Yes, to prevent from any forced line-break, and it also renders with a nice monospaced font.
Here are two screenshots comparing both results
- with
<pre>
- without
<pre>
If you want the non-monospaced font, so no <pre>, I can probably fix the result with CSS.
Fix #504 : honor the indentation in the MetadataFilter formatting