-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ChromaDB to >=0.6.0 and fix broken tests #530
Upgrade ChromaDB to >=0.6.0 and fix broken tests #530
Conversation
@pmeier For this test failure, should I typecast the return value of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks William, LGTM. I took the liberty and fixed the remaining stuff myself. To answer your question: actually casting the object to the right type, i.e. list[str]
is the best way to go here. The return type is Sequence[CollectionName]
with isinstance(CollectionName, str)
. Both the custom container type as well as the custom string type are "implementation details" of Chroma that we don't need to expose to the Ragna user.
The last thing before merge is to add a warning to the docstring of Chroma explaining that the NE
and and NOT_IN
metadata filters also return sources that don't have the corresponding key set at all and this is different than all other builtin source storages.
…er operators in Chroma
…oma-upgrade-0-6-1-address-operator-behavior
@pmeier I believe this PR is ready to be merged whenever you are ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so you can self-merge after addressing the final comments and after #534 is merged and CI is green. Thanks William!
This partially addresses #523 by updating the ChromaDB version to the latest 0.6.1 and patching particular test cases where ChromaDB's behavior differs from other databases.