Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact: drake modules #24

Merged
merged 2 commits into from
May 30, 2023
Merged

refact: drake modules #24

merged 2 commits into from
May 30, 2023

Conversation

OnofreTZK
Copy link
Collaborator

@OnofreTZK OnofreTZK commented May 24, 2023 •
edited
Loading

What changed

Rewrote Transaction and Block modules to use the functions inside Mempool and Chain and disposed of them.

The number of files changed because I needed to adapt the typing across the project after the refactoring.

Related Issues

#16
#12

@OnofreTZK OnofreTZK requested a review from amandsq May 24, 2023 23:56
@OnofreTZK OnofreTZK self-assigned this May 24, 2023
@OnofreTZK
Copy link
Collaborator Author

Lembrete @amandsq

amandsq
amandsq approved these changes May 29, 2023
View reviewed changes
Copy link

@amandsq amandsq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Da prox vez tenta não alterar muitos arquivos num pr só, fica ruim de corrigir

@OnofreTZK OnofreTZK merged commit ce49799 into dev May 30, 2023
@OnofreTZK OnofreTZK deleted the refact/drake-modules branch June 14, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandsq amandsq amandsq approved these changes

Assignees

@OnofreTZK OnofreTZK

Labels
Sheldrake: improvement improve the code or infra Sheldrake: invalid business logic This doesn't seem right Sheldrake: technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnofreTZK @amandsq