[Do Not Merge] Qubit release #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanclarke
reviewed
Oct 1, 2019
src/index.js
Outdated
| // We clone the options object because we mutate it later on. If we don't, then | ||
| // issues crop up if the caller re-uses the same options object between calls | ||
| // to this function. | ||
| options = clone(options); |
There was a problem hiding this comment.
options = { ...options } and you don't need an extra dependency
There was a problem hiding this comment.
should be equivalent to a shallow clone
There was a problem hiding this comment.
They don't use object spread anywhere in this repo, I didn't want to introduce it in case it was intentional (for support of older node versions perhaps)
alanclarke
approved these changes
Oct 1, 2019
oliverwoodings
force-pushed
the
qubit-release
branch
from
318243d to
33f5dee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.