Fix 6-year old padding bug, upgrade dependencies #5
+4,379
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was identified through SonarQube!
We have been incorrectly constructing ISO date strings for over 6 years now, which is ironic because the purpose of JSON bourne is to correctly encode dates and other things to the correct standards 🤦
The bug is due to the
padfunction not supporting a length parameter, but when used in code it was assumed that it does. This means that if the millisecond component of the date being stringified was less than 100, it would only be 2 characters long instead of being correctly padded to 3, and if it was less than 10, it would be 1 character!Luckily this hasn't actually caused any issues because most date libraries will be able to deal with the missing digits.
I had to update basically every dependency to get this working lol.