Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add RxClippedRectUtils.observeClippedRect(gui) #513

Merged
merged 31 commits into from
Nov 6, 2024
Merged

feat: Add RxClippedRectUtils.observeClippedRect(gui) #513

merged 31 commits into from
Nov 6, 2024

Conversation

Quenty
Copy link
Owner

@Quenty Quenty commented Oct 24, 2024 •
edited by github-actions bot
Loading

This pull request introduces multiple new features, performance improvements, bug fixes, and refactorings, primarily focusing on enhancing observable functionality, memory optimization, and code structure. The changes include:

New Features

  • Observable and Utility Enhancements
    • Added RxClippedRectUtils.observeClippedRect(gui) to facilitate observation of clipped rectangles.
    • Introduced RectUtils package for utility functions related to rectangular shapes and geometry.
    • Implemented StateStack:PushBrio, allowing for state management with Brio-like behavior.
    • Added __iter implementations to enable iteration over specific data structures.
    • Enhanced avatar handling with new Promise-based rules.
    • Developed an initial version of an observable sorted list and accompanying observable list utilities.
    • Introduced ObservableSubscriptionTable:Fail(key) method for enhanced subscription management.
    • Incorporated Rx.combineLatestDefer for optimized handling of multiple observable streams.

Performance Improvements

  • Optimized iteration, memory usage, and observable subscriptions for increased efficiency.
  • Enhanced performance in category checks and symbol handling.
  • Cached canFire() result for improved performance in subscription and event handling.
  • Made use of ObservableSubscriptionTable and stopped debug validation in integrations for performance gains.

Bug Fixes

  • Fixed stack trace readability and clarity.
  • Corrected an issue with mouse scroll detection logic.
  • Ensured BodyColor observation is handled accurately.
  • Adjusted clipping state computation for unparented items to return zero.
  • Improved deletion checks and fixed various state issues for reliable functionality.

Refactoring and Code Cleanup

  • Refactored event handling to support reusable components beyond Signal.
  • Improved symbol handling and code readability.
  • Cleaned up minor code inconsistencies and enhanced overall structure for maintainability.

Documentation

  • Updated README.md to include new packages and reflect recent changes.

These changes enhance observability, improve performance, and offer a more structured and maintainable codebase.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
# or 
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]

Quenty added 30 commits November 6, 2024 14:11
@Quenty
feat: Add RxClippedRectUtils.observeClippedRect(gui)
26d5933
@Quenty
feat: Add RectUtils package
7a99464
@Quenty
docs: Update README.md with list of new packages
5fed349
@Quenty
fix: Better stack traces
247ce9b
@Quenty
feat: Add StateStack:PushBrio
afec365
@Quenty
perf: Use ObservableSubscriptionTable and stop debug validating integ…
9d8e66b 
…rity
@Quenty
fix: Mouse scrolling scrolling check
2742ac4
@Quenty
fix: BodyColor observation is done correctly
b1c74cf
@Quenty
feat: Add __iter implementations
dd6db9a
@Quenty
fix: Don't check if we're cleaned up
49aa695
@Quenty
fix: Include dependency
2a0752d
@Quenty
feat: Promise avatar rules properly
66a3833
@Quenty
perf: Check canFire() and cache result
34fc3d9
@Quenty
feat: Add unfinished observable sorted list
c7e9817
@Quenty
fix: clip state computes zero for unparented items
8d355c1
@Quenty
feat: Broken observable list
4f8a551
@Quenty
feat: More stuff broken, but it's getting there
d141e80
@Quenty
fix: Apparently working list
e7a19a7
@Quenty
refactor: Event handling is reusable for classes besides Signal
d8fcaa0
@Quenty
fix: Fix some state issues and improve performance
69305a7
@Quenty
refactor: Make perf slightly better
3cf71dd
@Quenty
perf: Improve iteration perf
40ebb7a
@Quenty
fix: Slightly cleaner code
d0a9822
@Quenty
feat: Optimize memory and perf with combineLatestDefer
3bed556
@Quenty
feat: Add ObservableSubscriptionTable:Fail(key)
0bb3fae
@Quenty
feat: Specifically check for symbols
374df56
@Quenty
perf: Better perf check on category
594d5bb
@Quenty
feat: Use Rx.combineLatestDefer
3ca0d3f
@Quenty
refactor: Symbol improvements
175c9d3
@Quenty
fix: Fix deletion checks (maybe not very well tested)
71c6a99
@Quenty Quenty force-pushed the users/quenty/rect branch from ba35cc8 to 71c6a99 Compare November 6, 2024 22:11
@Quenty Quenty changed the title users/quenty/rect feat: Add RxClippedRectUtils.observeClippedRect(gui) Nov 6, 2024
@Quenty Quenty merged commit 78c11f0 into main Nov 6, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

🚀 PR was released in @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected], @quenty/[email protected] 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Nov 6, 2024
@Quenty Quenty deleted the users/quenty/rect branch January 14, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Quenty