fix: Fix ObserveAtIndex on ObservableSortedList #517
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
ObserveAtIndex
returns the node instead of the data which breaks a few packages. SwitchingRx.start
toRx.map
seems to fix the problem and give the desired behavior, but I'm not 100% sure if this is the intended behavior or if this would break anything.📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via: