Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix ObserveAtIndex on ObservableSortedList #517

Closed
wants to merge 1 commit into from

Conversation

unrooot
Copy link
Collaborator

@unrooot unrooot commented Nov 9, 2024

Currently, ObserveAtIndex returns the node instead of the data which breaks a few packages. Switching Rx.start to Rx.map seems to fix the problem and give the desired behavior, but I'm not 100% sure if this is the intended behavior or if this would break anything.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
npm install @quenty/[email protected]
# or 
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]
yarn add @quenty/[email protected]

@unrooot unrooot self-assigned this Nov 9, 2024
@unrooot unrooot requested a review from Quenty November 9, 2024 04:01
@unrooot
Copy link
Collaborator Author

unrooot commented Nov 9, 2024

One more thing to note, ObservableSortedList:ObserveIndexByKey() uses Rx.startFrom, which may be worth checking to make sure is also intended.

@unrooot
Copy link
Collaborator Author

unrooot commented Nov 9, 2024

it also doesnt seem to respect the observeValue that's passed to it when you add something

@Quenty
Copy link
Owner

Quenty commented Nov 11, 2024

See #518 instead

@unrooot
Copy link
Collaborator Author

unrooot commented Nov 12, 2024

closing since fixed in #518

@unrooot unrooot closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants