Skip to content

Commit

Permalink
Unskip 1 test
Browse files Browse the repository at this point in the history
  • Loading branch information
trzysiek committed Dec 28, 2024
1 parent e701090 commit 14e3d03
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
3 changes: 0 additions & 3 deletions quesma/quesma/search_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,6 @@ func TestSearchHandler(t *testing.T) {

for i, tt := range testdata.TestsSearch {
t.Run(fmt.Sprintf("%s(%d)", tt.Name, i), func(t *testing.T) {
if i == 37 {
t.Skip("Regexp seems to be broken because of some transformations")
}
var db *sql.DB
var mock sqlmock.Sqlmock
if len(tt.WantedRegexes) > 0 {
Expand Down
6 changes: 4 additions & 2 deletions quesma/testdata/requests.go
Original file line number Diff line number Diff line change
Expand Up @@ -2254,12 +2254,14 @@ var TestsSearch = []SearchTestCase{
},
"track_total_hits": false
}`,
[]string{`"field" LIKE '%\\___'`}, // escaping _ twice ("\\_") seemed wrong, but it actually works in Clickhouse!
// Escaping _ twice ("\\_") seemed wrong, but it actually works in Clickhouse!
// \\\\ means 2 escaped backslashes, actual returned string is "\\"
[]string{`"field" LIKE '%\\___'`},
model.ListAllFields,
[]string{
`SELECT "message" ` +
`FROM ` + TableName + ` ` +
`WHERE "field" LIKE '%\\___' ` +
`WHERE "field" LIKE '%\\\\___' ` +
`LIMIT 10`,
},
[]string{},
Expand Down

0 comments on commit 14e3d03

Please sign in to comment.