Skip to content

Commit

Permalink
Discovered table should not be virtual by default (#932)
Browse files Browse the repository at this point in the history
Following config 
```
  '*':
    target: [ my-clickhouse-data-source ]
```
lead to wrong decision about using `common table`
  • Loading branch information
pdelewski authored Oct 31, 2024
1 parent 02b8318 commit 3b7cce6
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion quesma/clickhouse/table_discovery.go
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,8 @@ func (td *tableDiscovery) autoConfigureTables(tables map[string]map[string]colum
} else {
maybeTimestampField = td.tableTimestampField(databaseName, table, ClickHouse)
}
configuredTables[table] = discoveredTable{table, databaseName, columns, config.IndexConfiguration{}, comment, createTableQuery, maybeTimestampField, true}
const isVirtualTable = false
configuredTables[table] = discoveredTable{table, databaseName, columns, config.IndexConfiguration{}, comment, createTableQuery, maybeTimestampField, isVirtualTable}

}
for tableName, table := range configuredTables {
Expand Down

0 comments on commit 3b7cce6

Please sign in to comment.