Remove table verifier (#979)

Produces a lot of noisy and confusing log lines. Remove that.
QuesmaOrg · Nov 13, 2024 · 4a9817e · 4a9817e
1 parent 2cbc0da
commit 4a9817e
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 85 deletions.
diff --git a/quesma/clickhouse/table_discovery.go b/quesma/clickhouse/table_discovery.go
@@ -45,7 +45,6 @@ type TableDiscovery interface {
 type tableDiscovery struct {
 	cfg                               *config.QuesmaConfiguration
 	dbConnPool                        *sql.DB
-	tableVerifier                     tableVerifier
 	tableDefinitions                  *atomic.Pointer[TableMap]
 	tableDefinitionsAccessUnixSec     atomic.Int64
 	tableDefinitionsLastReloadUnixSec atomic.Int64
@@ -164,7 +163,6 @@ func (td *tableDiscovery) ReloadTableDefinitions() {
 	configuredTables = td.readVirtualTables(configuredTables)
 
 	td.ReloadTablesError = nil
-	td.verify(configuredTables)
 	td.populateTableDefinitions(configuredTables, databaseName, td.cfg)
 }
 
@@ -389,17 +387,6 @@ func (td *tableDiscovery) TableDefinitions() *TableMap {
 	return td.tableDefinitions.Load()
 }
 
-func (td *tableDiscovery) verify(tables map[string]discoveredTable) {
-	for _, table := range tables {
-		logger.Info().Msgf("verifying table %s", table.name)
-		if correct, violations := td.tableVerifier.verify(table); correct {
-			logger.Debug().Msgf("table %s verified", table.name)
-		} else {
-			logger.Warn().Msgf("table %s verification failed: %s", table.name, violations)
-		}
-	}
-}
-
 func resolveColumn(colName, colType string) *Column {
 	isNullable := false
 	if isNullableType(colType) {

diff --git a/quesma/clickhouse/table_verification.go b/quesma/clickhouse/table_verification.go
diff --git a/quesma/clickhouse/table_verification_test.go b/quesma/clickhouse/table_verification_test.go