Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new aggregation IP Range #1100

Merged
merged 8 commits into from
Dec 27, 2024
Merged

new aggregation IP Range #1100

merged 8 commits into from
Dec 27, 2024

Conversation

trzysiek
Copy link
Member

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 12, 2024 •
edited
Loading

Deploying quesma with  Cloudflare Pages  Cloudflare Pages

Latest commit: e52f4c6
Status: ✅  Deploy successful!
Preview URL: https://00097a4f.quesma.pages.dev
Branch Preview URL: https://ip-range-aggr.quesma.pages.dev

View logs

@trzysiek trzysiek marked this pull request as ready for review December 12, 2024 13:45
@trzysiek trzysiek requested a review from a team as a code owner December 12, 2024 13:45
jakozaur
jakozaur approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@jakozaur jakozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In long run, we should support IPv6 as well IP being integer types in ClickHouse, though this is still improvement.

quesma/model/bucket_aggregations/ip_range.go Outdated Show resolved Hide resolved
quesma/model/bucket_aggregations/ip_range.go Outdated Show resolved Hide resolved
quesma/queryparser/pancake_json_rendering.go Outdated Show resolved Hide resolved
@trzysiek trzysiek enabled auto-merge December 27, 2024 12:42
@trzysiek trzysiek added this pull request to the merge queue Dec 27, 2024
Merged via the queue into main with commit 820fdeb Dec 27, 2024
5 checks passed
@trzysiek trzysiek deleted the ip_range-aggr branch December 27, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakozaur jakozaur jakozaur approved these changes

@nablaone nablaone Awaiting requested review from nablaone nablaone is a code owner automatically assigned from QuesmaOrg/engineering

@mieciu mieciu Awaiting requested review from mieciu mieciu is a code owner automatically assigned from QuesmaOrg/engineering

@avelanarius avelanarius Awaiting requested review from avelanarius avelanarius is a code owner automatically assigned from QuesmaOrg/engineering

@pdelewski pdelewski Awaiting requested review from pdelewski pdelewski is a code owner automatically assigned from QuesmaOrg/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trzysiek @jakozaur