Ingest - types testing #1129
Merged
Ingest - types testing #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nablaone
requested review from
jakozaur,
mieciu,
trzysiek,
avelanarius and
pdelewski
pdelewski
reviewed
Dec 22, 2024
trzysiek
reviewed
Dec 22, 2024
trzysiek
reviewed
Dec 22, 2024
trzysiek
reviewed
Dec 22, 2024
trzysiek
reviewed
Dec 22, 2024
trzysiek
reviewed
Dec 22, 2024
ci/it/testcases/test_ingest.go
Outdated
Comment on lines
688
to
699
| // Struct to parse only the `fields` tree | ||
| type Hit struct { | ||
| Fields map[string][]string `json:"fields"` | ||
| } | ||
|
|
||
| type HitsWrapper struct { | ||
| Hits []Hit `json:"hits"` | ||
| } | ||
|
|
||
| type Response struct { | ||
| Hits HitsWrapper `json:"hits"` | ||
| } |
There was a problem hiding this comment.
Ah, and they are redeclared here ;) One of two declarations should probably go.
|
I like this a lot! Left a few nitpicks myself + there's a more important Przemek's question. |
trzysiek
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an ingest test to check what types are supported. The test is quite strict right now. It compares the ingested field value literally with the query result. A less strict human/Kibana-acceptable comparison will be added in the future.
It prints the following table: