Fix ids query DSL
#1135
Merged
Fix ids query DSL
#1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trzysiek
requested review from
nablaone,
jakozaur,
mieciu,
avelanarius and
pdelewski
pdelewski
reviewed
Dec 22, 2024
| switch len(t.Exprs) { | ||
| case 0: | ||
| logger.WarnWithThrottling("VisitTuple", "TupleExpr with no expressions") | ||
| return "()" |
There was a problem hiding this comment.
Just to be consistent, consider returning tuple()
|
LGTM :) |
pdelewski
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By accident I noticed our SQL generated for
idslooks quite nonsensical, e.g. that's what's generated for my new very simple request:Also noticed we have 0 tests for this query. Fixing those 2 things here.
(adding
TupleExprfor just this 1 usecase might seem unnecessary, but it's needed in my 2 other open PRs, so I'd do that)Also, minor: changed
return model.NewSimpleQuery(nil, false)to more descriptivereturn model.NewSimpleQueryInvalid()everywhere.