Terms: start supporting exclude param
#1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trzysiek
commented
Dec 27, 2024
Comment on lines
+5105
to
+5138
| ExpectedPancakeSQL: ` | ||
| SELECT "aggr__terms1__parent_count", "aggr__terms1__key_0", | ||
| "aggr__terms1__count", "metric__terms1__metric1_col_0", | ||
| "aggr__terms1__terms2__parent_count", "aggr__terms1__terms2__key_0", | ||
| "aggr__terms1__terms2__count", "metric__terms1__terms2__metric2_col_0" | ||
| FROM ( | ||
| SELECT "aggr__terms1__parent_count", "aggr__terms1__key_0", | ||
| "aggr__terms1__count", "metric__terms1__metric1_col_0", | ||
| "aggr__terms1__terms2__parent_count", "aggr__terms1__terms2__key_0", | ||
| "aggr__terms1__terms2__count", "metric__terms1__terms2__metric2_col_0", | ||
| dense_rank() OVER (ORDER BY "aggr__terms1__count" DESC, | ||
| "aggr__terms1__key_0" ASC) AS "aggr__terms1__order_1_rank", | ||
| dense_rank() OVER (PARTITION BY "aggr__terms1__key_0" ORDER BY | ||
| "aggr__terms1__terms2__count" DESC, "aggr__terms1__terms2__key_0" ASC) AS | ||
| "aggr__terms1__terms2__order_1_rank" | ||
| FROM ( | ||
| SELECT sum(count(*)) OVER () AS "aggr__terms1__parent_count", | ||
| if("Carrier" NOT IN tuple('a', 'b'), "Carrier", NULL) AS "aggr__terms1__key_0", | ||
| sum(count(*)) OVER (PARTITION BY "aggr__terms1__key_0") AS | ||
| "aggr__terms1__count", | ||
| avgOrNullMerge(avgOrNullState("DistanceMiles")) OVER (PARTITION BY | ||
| "aggr__terms1__key_0") AS "metric__terms1__metric1_col_0", | ||
| sum(count(*)) OVER (PARTITION BY "aggr__terms1__key_0") AS | ||
| "aggr__terms1__terms2__parent_count", | ||
| "DestCityName" AS "aggr__terms1__terms2__key_0", | ||
| count(*) AS "aggr__terms1__terms2__count", | ||
| sumOrNull("AvgTicketPrice") AS "metric__terms1__terms2__metric2_col_0" | ||
| FROM __quesma_table_name | ||
| GROUP BY if("Carrier" NOT IN tuple('a', 'b'), "Carrier", NULL) AS | ||
| "aggr__terms1__key_0", "DestCityName" AS "aggr__terms1__terms2__key_0")) | ||
| WHERE ("aggr__terms1__order_1_rank"<=3 AND "aggr__terms1__terms2__order_1_rank" | ||
| <=2) | ||
| ORDER BY "aggr__terms1__order_1_rank" ASC, | ||
| "aggr__terms1__terms2__order_1_rank" ASC`, |
There was a problem hiding this comment.
tested this long SQL with Clickhouse and it works exactly as we want 🎉
trzysiek
force-pushed
the
terms-exclude
branch
from
ef8b2ec to
2f94547
Compare
trzysiek
requested review from
nablaone,
jakozaur,
mieciu,
avelanarius and
pdelewski
jakozaur
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1085
TODO (next PRs):
includeparameter can probably be quite easily handled the same wayIssue from the issue works fine now:
