V2 route handling #1149
Merged
V2 route handling #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mieciu
requested review from
nablaone,
jakozaur,
trzysiek,
avelanarius and
pdelewski
pdelewski
requested changes
Jan 2, 2025
There was a problem hiding this comment.
Please switch to v2 temporarily, by changing quesma_v2 = true in main.go. It seems that unit tests require update.
go test
# quesma/quesma [quesma/quesma.test]
./search_common_table_test.go:332:25: queryRunner.handleSearch undefined (type *QueryRunner has no field or method handleSearch, but does have method HandleSearch)
./search_norace_test.go:56:16: queryRunner.handleSearch undefined (type *QueryRunner has no field or method handleSearch, but does have method HandleSearch)
./search_norace_test.go:128:22: queryRunner.handleSearch undefined (type *QueryRunner has no field or method handleSearch, but does have method HandleSearch)
./search_opensearch_test.go:64:27: queryRunner.handleSearch undefined (type *QueryRunner has no field or method handleSearch, but does have method HandleSearch)
./search_opensearch_test.go:200:31: queryRunner.handleSearch undefined (type *QueryRunner has no field or method handleSearch, but does have method HandleSearch)
./search_test.go:95:26: queryRunner.handleAsyncSearch undefined (type *QueryRunner has no field or method handleAsyncSearch, but does have method HandleAsyncSearch)
./search_test.go:146:26: queryRunner.handleAsyncSearch undefined (type *QueryRunner has no field or method handleAsyncSearch, but does have method HandleAsyncSearch)
./search_test.go:337:26: queryRunner.handleSearch undefined (type *QueryRunner has no field or method handleSearch, but does have method HandleSearch)
./search_test.go:397:26: queryRunner.handleSearch undefined (type *QueryRunner has no field or method handleSearch, but does have method HandleSearch)
./search_test.go:441:23: queryRunner.handleSearch undefined (type *QueryRunner has no field or method handleSearch, but does have method HandleSearch)
./search_test.go:441:23: too many errors
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
IT seal of approval https://github.com/QuesmaOrg/quesma/actions/runs/12581972994 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1119 I noticed that a lot of this code could already safely land in
mainbranch and act as "general bridge" between the present andv2api.Notable changes are switching to interfaces (
LogManagerIface/QueryRunnerIFace). Therefore we could introduce the intermediate layer in route handlers for queries which can use both old and new structures (new log manager using v2 api, etc.).Also, the
_field_capsgot more specific as it no longer accept full Quesma config to be more suited for being called within a processor (which just has index config).