Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More router_v2 portability (terms_enum + minor additions) #1153

Merged
merged 1 commit into from
Jan 3, 2025
Merged

More router_v2 portability (terms_enum + minor additions) #1153

merged 1 commit into from
Jan 3, 2025

Conversation

mieciu
Copy link
Member

@mieciu mieciu commented Jan 3, 2025 •
edited
Loading

Mainly that's just adding 2 more methods to LogManagerIFace so that terms_enum request can be handled using v2 api as well.
Another round of "general changes" helpful for #1119

@mieciu mieciu marked this pull request as ready for review January 3, 2025 10:20
@mieciu mieciu requested a review from a team as a code owner January 3, 2025 10:20
@mieciu mieciu added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit 58303d8 Jan 3, 2025
5 checks passed
@mieciu mieciu deleted the router-v2-upgrades-contd branch January 3, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdelewski pdelewski pdelewski approved these changes

@nablaone nablaone Awaiting requested review from nablaone nablaone is a code owner automatically assigned from QuesmaOrg/engineering

@jakozaur jakozaur Awaiting requested review from jakozaur jakozaur is a code owner automatically assigned from QuesmaOrg/engineering

@trzysiek trzysiek Awaiting requested review from trzysiek trzysiek is a code owner automatically assigned from QuesmaOrg/engineering

@avelanarius avelanarius Awaiting requested review from avelanarius avelanarius is a code owner automatically assigned from QuesmaOrg/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mieciu @pdelewski