Get rid of additional QueryRunner #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mieciu
requested review from
nablaone,
jakozaur,
trzysiek,
avelanarius and
pdelewski
jakozaur
approved these changes
Jan 4, 2025
|
|
||
| // DummyTableResolver is a dummy implementation of TableResolver to satisfy the QueryRunner and make it be compatible with the v2 api | ||
| // thanks to this we can reuse the existing QueryRunner implementation without any changes. | ||
| type DummyTableResolver struct{} |
There was a problem hiding this comment.
I would consider naming it EmptyTableResolver as it better describes and we already use that name.
There was a problem hiding this comment.
I'll handle this in the next PR as this will have to also undergo a change related to common table handling 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the QueryRunner so that it relies on
clickhouse.LogManagerIFaceinstead of*clickhouse.LogManager.Having that, we won't need a duplicate of
QueryRunnerin #1119.Caveat: we're adding a that dumb dummy table resolver, but that's way simpler than having a copy of QueryRunner.
Lots of LoCs to save here 😉