Complete IngestProcessor v2 work #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mieciu
requested review from
nablaone,
jakozaur,
trzysiek,
avelanarius and
pdelewski
pdelewski
reviewed
Jan 13, 2025
quesma/processors/es_to_ch_ingest/elasticsearch_to_clickhouse_ingest_processor.go
Show resolved
Hide resolved
|
IT run for this PR, commit hash of 511c614 -> https://github.com/QuesmaOrg/quesma/actions/runs/12747717406 |
|
I'm ok with merging these changes. |
mieciu
force-pushed
the
complete-ingest-processor
branch
from
511c614 to
cb84ba4
Compare
halfway there config removal temporary move cleaned up fix the nil pointer fix test main back on track
mieciu
force-pushed
the
complete-ingest-processor
branch
from
cb84ba4 to
a836866
Compare
pdelewski
approved these changes
Jan 13, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 20, 2025
#1178 has just scratched the surface and was mostly about bridging the gap between v1 and v2 API. This PR is a continuation on v2 ingest processor. Fixing routing, doubled dependencies and many more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were few things to be finished there:
router_v2and handler functions pattern I did for the Query Processor