Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router fixes #1192

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Router fixes #1192

merged 6 commits into from
Jan 17, 2025

Conversation

mieciu
Copy link
Member

@mieciu mieciu commented Jan 16, 2025 •
edited
Loading

There are two big changes here:

  • the algorithm which merges routes when there are multiple fronted connectors (individual routes used to overwrite themselves)
  • findHandler in quesma/v2/core/mux.go changes, because it had pretty nasty issue that for given two mappings with the same paths it just took the first one, and if predicate didn't match - request was classified as non matching.

WARNING: This changes the behavior of the currently used router.

@mieciu mieciu marked this pull request as ready for review January 16, 2025 19:14
@mieciu mieciu requested a review from a team as a code owner January 16, 2025 19:14
pdelewski
pdelewski previously approved these changes Jan 17, 2025
View reviewed changes
@pdelewski pdelewski dismissed their stale review January 17, 2025 08:29

Integration tests failing

@mieciu
Copy link
Member Author

mieciu commented Jan 17, 2025

ITs: https://github.com/QuesmaOrg/quesma/actions/runs/12830773174

@pdelewski
Copy link
Contributor

LGTM :)

@mieciu mieciu enabled auto-merge January 17, 2025 14:27
@mieciu mieciu added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 0905091 Jan 17, 2025
5 checks passed
@mieciu mieciu deleted the routing-fixes branch January 17, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdelewski pdelewski pdelewski approved these changes

@nablaone nablaone Awaiting requested review from nablaone nablaone is a code owner automatically assigned from QuesmaOrg/engineering

@jakozaur jakozaur Awaiting requested review from jakozaur jakozaur is a code owner automatically assigned from QuesmaOrg/engineering

@trzysiek trzysiek Awaiting requested review from trzysiek trzysiek is a code owner automatically assigned from QuesmaOrg/engineering

@avelanarius avelanarius Awaiting requested review from avelanarius avelanarius is a code owner automatically assigned from QuesmaOrg/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mieciu @pdelewski