Comment out import of Vitess to fix error logging #1339
Merged
+183
−177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that JUST IMPORTING Vitess messes up logging in the entire
application.
Vitess code in its `init()` function (called before our `main`) redirects
stderr logging into its own logging implementation (which doesn't print
anything for us).
For now, I just commented out the code that imported (and used) Vitess.
Before the fix if the config validation failed, it wouldn't print
the cause of the failure. After this fix, the cause is now properly
printed out:
________
\_____ \ __ __ ____ ______ _____ _____
/ / \ \| | \_/ __ \ / ___// \\__ \
/ \_/. \ | /\ ___/ \___ \| Y Y \/ __ \_
\_____\ \_/____/ \___ >____ >__|_| (____ /
\__> \/ \/ \/ \/
2025/03/03 19:18:14 Config validation failed: 2 errors occurred:
* no frontend connectors defined
* no pipelines defined, must define at least one
avelanarius
requested review from
nablaone,
jakozaur,
stared,
trzysiek and
pdelewski
jakozaur
approved these changes
Mar 3, 2025
trzysiek
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that JUST IMPORTING Vitess messes up logging in the entire application.
Vitess code in its
init()function (called before ourmain) redirects stderr logging into its own logging implementation (which doesn't print anything for us): https://github.com/vitessio/vitess/blob/41a8d1dd323fb56e9dce88b29c64f9dc87b5a0fe/go/vt/logutil/logutil.go#L17-L18For now, I just commented out the code that imported (and used) Vitess.
Before the fix, if the config validation failed, it wouldn't print the cause of the failure. After this fix, the cause is now properly printed out: