Sum_bucket aggregation
#156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trzysiek
force-pushed
the
sum_bucket-aggregation
branch
2 times, most recently
from
3ab8fe8 to
e188067
Compare
pdelewski
reviewed
May 20, 2024
| func (cw *ClickhouseQueryTranslator) parseSumBucket(queryMap QueryMap) (aggregationType model.QueryType, success bool) { | ||
| sumBucketRaw, exists := queryMap["sum_bucket"] | ||
| if !exists { | ||
| return |
There was a problem hiding this comment.
Should not we explicitly return result?
There was a problem hiding this comment.
Don't know, seems shorter and easier to read for me this way
pdelewski
reviewed
May 20, 2024
| } | ||
| if returnMap, ok := rows[0].LastColValue().(model.JsonMap); ok { | ||
| return []model.JsonMap{returnMap} | ||
| } else { |
There was a problem hiding this comment.
Seems that this else is redundant
pdelewski
reviewed
May 20, 2024
| return resultRows // maybe null? | ||
| } | ||
| qp := queryprocessor.NewQueryProcessor(query.ctx) | ||
| parentFieldsCnt := len(parentRows[0].Cols) - 2 // -2, because row is [parent_cols..., current_key, current_value] |
There was a problem hiding this comment.
Can this be negative value?
There was a problem hiding this comment.
It should never be. Added a warn, though.
|
One second, I didn't change 1 thing after rebase. |
trzysiek
force-pushed
the
sum_bucket-aggregation
branch
2 times, most recently
from
c0ae484 to
4d5017f
Compare
jakozaur
approved these changes
May 21, 2024
trzysiek
force-pushed
the
sum_bucket-aggregation
branch
3 times, most recently
from
f13b7a0 to
60e6356
Compare
trzysiek
force-pushed
the
sum_bucket-aggregation
branch
from
02f7650 to
6676224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests to this PR showed 2 issues in all pipeline aggregations:
But especially as those are issues in all types of pipeline aggr, I'd fix those in separate PR.
Some screens:
