Search-resolver in handleSearchCommon #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivovarit
force-pushed
the
multi-index-search
branch
5 times, most recently
from
8587069 to
8cb2b3c
Compare
pivovarit
changed the title
pivovarit
changed the title
|
Pushing this change already since it's getting incomprehensible |
pivovarit
force-pushed
the
multi-index-search
branch
from
4343c1b to
90e6129
Compare
jakozaur
approved these changes
May 6, 2024
pivovarit
force-pushed
the
multi-index-search
branch
from
90e6129 to
f38dc50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this change, I integrate the source resolver with the search logic and use it to determine the strategy. This change is supposed to be neutral, so the original strategy is preserved, but all the search logic moved into a loop, which makes it multiple-table friendly.
Depends on: