Hit response refactor #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jakozaur
commented
Jun 7, 2024
| @@ -46,7 +46,6 @@ type ( | |||
| NoDBQuery bool // true <=> we don't need query to DB here, true in some pipeline aggregations | |||
| Parent string // parent aggregation name, used in some pipeline aggregations | |||
| Aggregators []Aggregator // keeps names of aggregators, e.g. "0", "1", "2", "suggestions". Needed for JSON response. | |||
| SubSelect string | |||
jakozaur
commented
Jun 7, 2024
| @@ -99,14 +99,6 @@ func (cw *ClickhouseQueryTranslator) MakeAsyncSearchResponse(ResultSet []model.Q | |||
| return &response, nil | |||
| } | |||
|
|
|||
| func (cw *ClickhouseQueryTranslator) MakeAsyncSearchResponseMarshalled(ResultSet []model.QueryResultRow, query *model.Query, asyncRequestIdStr string, isPartial bool) ([]byte, error) { | |||
There was a problem hiding this comment.
This was function only used twice in tests. Inlining in tests makes more sense.
pivovarit
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move response creation to parsing so we would able to leverage parsing features to set the right options.
We should also relax condition; the hits could be any query, not necessarily the last one.