Add support for DateTime values in metrics aggregations #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trzysiek
force-pushed
the
fix-datetime-metrics-aggr
branch
7 times, most recently
from
cac3a27 to
f0558ad
Compare
jakozaur
approved these changes
May 8, 2024
trzysiek
force-pushed
the
fix-datetime-metrics-aggr
branch
from
f0558ad to
f9ae67d
Compare
trzysiek
force-pushed
the
fix-datetime-metrics-aggr
branch
from
e43f344 to
6234283
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max,min, andpercentilesaggregations need separate handling forDateTimefields, the response is slightly different. Added that + 3 tests, one for each.Before:
percentilesdidn't work at all,min/max- a bit.After: