Quickfix incorrect tests #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm, maybe it would be good to add comment about this strange behaviour |
pdelewski
approved these changes
Jun 7, 2024
|
Sure, great idea, sorry that I didn't do that already. |
pdelewski
pushed a commit
that referenced
this pull request
Jun 9, 2024
It's a bit concerning that these tests passed most of the time, even though we expected 1 query in mock, but actually sent 2. Maybe it's introduced by this newly added `mock.MatchExpectationsInOrder(false)`? Maybe sqlmock's bug? Maybe my bug? I'll try to inspect that for a bit, but it seems to solve the flakiness + results should **now** be correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit concerning that these tests passed most of the time, even though we expected 1 query in mock, but actually sent 2 to the DB...
Maybe it's introduced by this newly added
mock.MatchExpectationsInOrder(false)? Maybe sqlmock's bug? Maybe my bug?I'll try to inspect that for a bit, but it seems to solve the flakiness + results should now be correct