Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI refactor #39

Merged
merged 5 commits into from
May 6, 2024
Merged

UI refactor #39

merged 5 commits into from
May 6, 2024

Conversation

jakozaur
Copy link
Contributor

@jakozaur jakozaur commented May 6, 2024

This is a giant change. Mostly move and rename with minor delete of unused code.

Principle:

  • replace html_pages and html_panels with filer per each tab
  • reduce the amount of exposed public API using internal and private name
  • keep every non-test file below 300 lines

Long term goals:

  • Make UI configurable (e.g. port, disable debug, limit amount of messages)
  • Be able to refactor so one UI can attach to multiple quesma consoles
  • Make modular UI, so it's easy to add new tabs, even for occasional use case

More changes will follow (e.g. more packages, configurability)

@jakozaur jakozaur requested a review from a team as a code owner May 6, 2024 10:36
@jakozaur jakozaur requested review from nablaone, mieciu, pivovarit, trzysiek and pdelewski and removed request for a team May 6, 2024 10:36
Copy link
Member

@nablaone nablaone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the internal package.

LGTM

@pivovarit pivovarit merged commit d54389f into main May 6, 2024
4 checks passed
@pivovarit pivovarit deleted the ui-refactor branch May 6, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants