Second part of reporting unsupported query types #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trzysiek
force-pushed
the
unsupported-query-dsl
branch
6 times, most recently
from
6a3ccc2 to
d8f8f26
Compare
trzysiek
force-pushed
the
unsupported-query-dsl
branch
from
d8f8f26 to
51bff64
Compare
jakozaur
approved these changes
May 7, 2024
jakozaur
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically did the same thing as with aggregations. Tested receiving every
Query DSLquery type possible, to see if we catch it. We seem to. E.g. at the screensshapeis aQuery DSLunsupported query, whileip_rangeis an aggregation - you can see both.In the code I needed to only start returning if parsing went fine or not for bool expressions, as they can contain subqueries with all other
Query DSLqueries.