Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jacek request UI #61

Merged
merged 8 commits into from
May 8, 2024
Merged

Jacek request UI #61

merged 8 commits into from
May 8, 2024

Conversation

jakozaur
Copy link
Contributor

@jakozaur jakozaur commented May 8, 2024

Investigating a request requires looking at two screens:

  • logs
  • list of request of size one

I unify it to a single screen:
Screenshot 2024-05-08 at 11 46 34
Screenshot 2024-05-08 at 11 46 20

@jakozaur jakozaur requested a review from a team as a code owner May 8, 2024 09:48
@jakozaur jakozaur requested review from nablaone, mieciu, pivovarit, trzysiek and pdelewski and removed request for a team May 8, 2024 09:48
trzysiek
trzysiek approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@trzysiek trzysiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked it out and it looks great to me. Much better user experience.

@jakozaur jakozaur enabled auto-merge (squash) May 8, 2024 19:30
@jakozaur jakozaur merged commit e354b8f into main May 8, 2024
4 checks passed
@jakozaur jakozaur deleted the jacek-request-ui branch May 8, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trzysiek trzysiek trzysiek approved these changes

@nablaone nablaone Awaiting requested review from nablaone nablaone is a code owner automatically assigned from QuesmaOrg/engineering

@mieciu mieciu Awaiting requested review from mieciu mieciu is a code owner automatically assigned from QuesmaOrg/engineering

@pivovarit pivovarit Awaiting requested review from pivovarit pivovarit is a code owner automatically assigned from QuesmaOrg/engineering

@pdelewski pdelewski Awaiting requested review from pdelewski pdelewski is a code owner automatically assigned from QuesmaOrg/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakozaur @trzysiek