Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test flakiness - bump timeouts #64

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

trzysiek
Copy link
Member

@trzysiek trzysiek commented May 8, 2024

Those new tests for errors in UI per query type passed 100/100 times on my PC, also they've been here for some time, and noone reported flakiness. But it happened to me now, so I guess I need to increase timeouts a bit.

I also remove 1 print from tests, I guess it shouldn't be there.

@trzysiek trzysiek requested a review from a team as a code owner May 8, 2024 16:58
@trzysiek trzysiek requested review from nablaone, jakozaur, mieciu, pivovarit and pdelewski and removed request for a team May 8, 2024 16:58
@trzysiek trzysiek enabled auto-merge (squash) May 8, 2024 16:59
@trzysiek trzysiek merged commit 92aebdf into main May 8, 2024
4 checks passed
@trzysiek trzysiek deleted the quickfix-test-flakiness branch May 8, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants