Generalizing sql query processing 1 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdelewski
force-pushed
the
generalize-process-sql-query
branch
2 times, most recently
from
3da5755 to
8cbb01b
Compare
pdelewski
changed the title
trzysiek
reviewed
May 9, 2024
trzysiek
reviewed
May 9, 2024
trzysiek
reviewed
May 9, 2024
|
Generally looks great, seems like we can unify a lot of this adhoc-written code. |
pdelewski
force-pushed
the
generalize-process-sql-query
branch
from
aeeee31 to
991a3d9
Compare
trzysiek
approved these changes
May 9, 2024
Merged
jakozaur
added a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Process...Queryfunc (q *Query) StringFromColumnsto be almost in pair withfunc (q *Query) String. The final goal would be to have just one function