Quickfix: Percentile combinator
#780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trzysiek
force-pushed
the
percentile-combinator
branch
3 times, most recently
from
b64e51c to
3267540
Compare
trzysiek
requested review from
nablaone,
jakozaur,
mieciu,
avelanarius and
pdelewski
jakozaur
requested changes
Sep 23, 2024
| // We probably could simplify the code a bit to use "quantile" instead, and just "sum" here. | ||
| if strings.HasPrefix(origFunc.Name, "quantiles") { | ||
| return origFunc, "sumArray", nil | ||
| } |
There was a problem hiding this comment.
Sum of quantiles does not seem correct. I would add quantiles to same condition that creates State and Merge, but likely you need to do some parsing.
trzysiek
force-pushed
the
percentile-combinator
branch
from
dcc2c68 to
dc45c02
Compare
trzysiek
force-pushed
the
percentile-combinator
branch
from
dc45c02 to
4e8b692
Compare
jakozaur
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quickfix to some problem encountered during QA in Kibana. Request saved as a test.
Before:
After: (same as Elastic's, which is at
:5602)