Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix applyPhysicalFromExpression for auto-discovery #792

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix applyPhysicalFromExpression for auto-discovery #792

merged 1 commit into from
Sep 24, 2024

Conversation

mieciu
Copy link
Member

@mieciu mieciu commented Sep 24, 2024

Small regression I've found while working on auth. In auto discovery mode, there's no index configuration, so we shall fallback to false for useCommonTable instead of returning an error

@mieciu mieciu requested a review from nablaone September 24, 2024 09:06
@mieciu mieciu requested a review from a team as a code owner September 24, 2024 09:06
@mieciu mieciu enabled auto-merge September 24, 2024 09:29
@mieciu mieciu added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit a546fb4 Sep 24, 2024
5 checks passed
@mieciu mieciu deleted the autodisco-commontable branch September 24, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avelanarius avelanarius avelanarius approved these changes

@nablaone nablaone Awaiting requested review from nablaone

@jakozaur jakozaur Awaiting requested review from jakozaur jakozaur is a code owner automatically assigned from QuesmaOrg/engineering

@trzysiek trzysiek Awaiting requested review from trzysiek trzysiek is a code owner automatically assigned from QuesmaOrg/engineering

@pdelewski pdelewski Awaiting requested review from pdelewski pdelewski is a code owner automatically assigned from QuesmaOrg/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mieciu @avelanarius