Adding admin console auth #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple ElasticsearchAuth
Signed-off-by: Przemysław Hejman <[email protected]>
mieciu
requested review from
nablaone,
jakozaur,
trzysiek,
avelanarius and
pdelewski
nablaone
reviewed
Oct 9, 2024
|
Signed-off-by: Przemysław Hejman <[email protected]>
nablaone
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding admin console auth. This might seem really funny at glance with the whole empty
NewElasticsearchAuthProvider()which is essentially used only to add two routes, but in the future adding any oAuth provider should be trivial.In fact, I was able to create Google oAuth app and log in using my credentials.
For now however, we have a nice login screen asking for our Elasticsearch credentials. The whole logic is really in
HandleElasticsearchLogin.At this moment, if Elasticsearch cluster allows unauthenticated access, Quesma disables admin console auth.