Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better smoke test #84

Merged
merged 3 commits into from
May 11, 2024
Merged

Better smoke test #84

merged 3 commits into from
May 11, 2024

Conversation

jakozaur
Copy link
Contributor

Currently, we have not checked the results at all.

We need to check it in more detail:

  • ensure there are hits
  • does human style spot checking to spot columns mismatch

@jakozaur jakozaur requested a review from a team as a code owner May 10, 2024 19:47
@jakozaur jakozaur requested review from nablaone, mieciu, pivovarit, trzysiek and pdelewski and removed request for a team May 10, 2024 19:47
@jakozaur jakozaur merged commit 4cad0aa into main May 11, 2024
4 checks passed
@jakozaur jakozaur deleted the jacek-smoke-test branch May 11, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pivovarit pivovarit pivovarit approved these changes

@nablaone nablaone Awaiting requested review from nablaone nablaone is a code owner automatically assigned from QuesmaOrg/engineering

@mieciu mieciu Awaiting requested review from mieciu mieciu is a code owner automatically assigned from QuesmaOrg/engineering

@trzysiek trzysiek Awaiting requested review from trzysiek trzysiek is a code owner automatically assigned from QuesmaOrg/engineering

@pdelewski pdelewski Awaiting requested review from pdelewski pdelewski is a code owner automatically assigned from QuesmaOrg/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakozaur @pivovarit