Table Resolver #840
Merged
Table Resolver #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdelewski
reviewed
Oct 9, 2024
pdelewski
reviewed
Oct 9, 2024
pdelewski
reviewed
Oct 9, 2024
pdelewski
reviewed
Oct 9, 2024
| cfg: ingestConf, | ||
| resolver: &composedResolver{ | ||
| decisionLadder: []namedResolver{ | ||
| {"patternIsNotAllowed", patternIsNotAllowed}, |
There was a problem hiding this comment.
Where these callbacks are defined like patternIsNotAllowed?
nablaone
requested review from
jakozaur,
mieciu,
trzysiek,
avelanarius and
pdelewski
pdelewski
reviewed
Oct 10, 2024
pdelewski
reviewed
Oct 10, 2024
| @@ -265,6 +271,10 @@ func (q *QueryRunner) executePlan(ctx context.Context, plan *model.ExecutionPlan | |||
| } | |||
|
|
|||
| func (q *QueryRunner) handleSearchCommon(ctx context.Context, indexPattern string, body types.JSON, optAsync *AsyncQuery, queryLanguage QueryLanguage) ([]byte, error) { | |||
|
|
|||
| decision := q.tableResolver.Resolve(table_resolver.QueryPipeline, indexPattern) | |||
| table_resolver.TODO("handleSearchCommon", decision) | |||
There was a problem hiding this comment.
Do you already thought about dispatch implementation? (functionality of current TODOs)
There was a problem hiding this comment.
TODO is a marker function. It will be removed.
There was a problem hiding this comment.
I know it's marker but you need to do something based on decision and I'm asking about this implementation
There was a problem hiding this comment.
I had a vision, but I can't tell you how it will be implemented.
pdelewski
reviewed
Oct 10, 2024
pdelewski
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
Table Resolver. Table resolver answers the question "What will Quesma do for given index (or index pattern)?"It has three parts:
TableResolverinterface and implementationLimitations:
It doesn't perform any actions based on decision. Rules can be incomplete or simply wrong. It will be finished in the next PR.