Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickfix panic at Hdx #844

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Quickfix panic at Hdx #844

merged 3 commits into from
Oct 4, 2024

Conversation

trzysiek
Copy link
Member

@trzysiek trzysiek commented Oct 4, 2024

This request caused panic

POST /logs*/_search
{
  "_source": false,
  "fields": [
    {
      "field": "*",
      "include_unmapped": "true"
    },
    {
      "field": "reqTimeSec",
      "format": "strict_date_optional_time"
    }
  ],
  "highlight": {
    "fields": {
      "*": {}
    },
    "fragment_size": 2147483647,
    "post_tags": [
      "@/kibana-highlighted-field@"
    ],
    "pre_tags": [
      "@kibana-highlighted-field@"
    ]
  },
  "query": {
    "bool": {
      "filter": [
        {
          "range": {
            "timestamp": {
              "format": "strict_date_optional_time",
              "gte": "2024-10-01T11:12:46.174Z",
              "lte": "2024-10-14T11:27:46.174Z"
            }
          }
        }
      ],
      "must": [],
      "must_not": [],
      "should": []
    }
  },
  "runtime_mappings": {},
  "script_fields": {},
  "size": 0,
  "sort": [
    {
      "timestamp": {
        "format": "strict_date_optional_time",
        "order": "desc",
        "unmapped_type": "boolean"
      }
    },
    {
      "_doc": {
        "order": "desc",
        "unmapped_type": "boolean"
      }
    }
  ],
  "stored_fields": [
    "*"
  ],
  "track_total_hits": false,
  "version": true
}
Screenshot 2024-10-04 at 13 36 13 After: Screenshot 2024-10-04 at 13 48 18

return nil, fmt.Errorf("postProcessResults: plan.Queries is empty")
return results, nil
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a more natural logic for a function postprocessing results, doesn't it?

@trzysiek trzysiek marked this pull request as ready for review October 4, 2024 11:51
@trzysiek trzysiek requested a review from a team as a code owner October 4, 2024 11:51
@trzysiek trzysiek enabled auto-merge October 4, 2024 11:51
@trzysiek trzysiek added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit e4efaa6 Oct 4, 2024
5 checks passed
@trzysiek trzysiek deleted the quickfix-empty-check branch October 4, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants