Some random changes #867
Closed
Some random changes #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of small enhancements here: * During Kibana QA, I found out that it really happens a lot that in `order by: some_other_aggregation`, this aggregation is not a direct child, but some further descender in the aggregation tree, so added support for it (before `order by: "agg1"` worked, now `order by: "agg1>agg2>agg3"` also works (`agg2` is a child of `agg1`, `agg3` of `agg2`, etc.) * Before we had support for a) `order by: "2"` (where `2` is a metric aggr with single value like e.g. `avg`) b) `order by: "2.10"` (where `2` is a `percentile[s|_ranks]` aggr, and `10` is a percentile) Here added also support for `2.count`, `2.std_deviation`, and other stats from `stats` or `extended_stats` aggregations. * Before we could only order by 1 expression, 2 or more weren't supported. Fixed that. Sorry for quite a big PR, but it turned out to be like that out of necessity. E.g. I implemented the last point only because without it, proper tests for previous points would need to be much larger 😆 --------- Co-authored-by: Jacek Migdal <[email protected]>
Deploying quesma with
|
| Latest commit: |
05358fb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://857d9bdd.quesma.pages.dev |
| Branch Preview URL: | https://some-random-changes.quesma.pages.dev |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 31, 2024
Only few very minor changes need to still be ported from #867 It's first of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.