Fixing quesma common table dynamic mapping case, second approach #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdelewski
force-pushed
the
fixing-quesma-common-table-dynamic-mapping-case2
branch
2 times, most recently
from
1759962 to
23a61dd
Compare
pdelewski
force-pushed
the
fixing-quesma-common-table-dynamic-mapping-case2
branch
from
23a61dd to
749062d
Compare
pdelewski
requested review from
nablaone,
jakozaur,
mieciu,
trzysiek and
avelanarius
nablaone
approved these changes
Oct 15, 2024
| @@ -491,7 +494,10 @@ func (s *SchemaCheckPass) applyFullTextField(indexSchema schema.Schema, query *m | |||
|
|
|||
| for _, field := range indexSchema.Fields { | |||
| if field.Type.IsFullText() { | |||
| fullTextFields = append(fullTextFields, field.InternalPropertyName.AsString()) | |||
| // Take only fields that are ingested | |||
pdelewski
deleted the
fixing-quesma-common-table-dynamic-mapping-case2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second approach (1 - #878) of fixing a problem where mappings contains more fields than ingest and sql queries are based on this knowledge. In this approach we are not altering table to have all fields that were added by dynamic mapping but we based on field origin information and building queries according to that.