-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Just added a comment for testing #35
Open
Logonz
wants to merge
20
commits into
dev
Choose a base branch
from
sod-data
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function enhances the utility of DumpFunctions by providing a method to count the key-value pairs in a given table, which is useful for debugging and data handling scenarios.
Change AllIdStrings from a table of strings to a single concatenated string. This simplifies the handling of ID strings and improves performance by reducing the number of table operations. Update the GetNewIds function to use a hash set for existing IDs, improving the efficiency of ID lookups and ensuring new IDs are correctly identified. Remove unnecessary debug prints and comments for cleaner code.
This change introduces a new feature to generate a translation trie and HTML files for the localized strings in the project. The key changes include: - Added a new script `generate_translation_trie.lua` that creates a trie data structure from the translation strings and writes the translations to HTML files with segmentation support. - Updated the `main.lua` script to call the new `Compile_translations_to_html` function from `generate_translation_trie.lua`. - Added a `run.sh` script to execute the main script and a `Dockerfile` to build a Docker container for the project. - Updated the `CLI_Helpers.lua` script to handle file paths with backslashes correctly when loading script files. - Refactored the `l10n.lua` script to improve the handling of localization data. These changes improve the localization capabilities of the project by providing a more efficient way to manage and display the translated strings.
This change adds .gitignore files for the generated translation files and directories: - `.generate_database/.gitignore` - Ignores the `Translations` directory generated by the translation generation script - `translations/.gitignore` - Ignores the `translationsLookup.lua`, `translationsFiles.xml`, and `data/` files generated by the translation generation script These changes help keep the repository clean by excluding the generated translation files from being tracked by Git.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.