Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viktor/backend #41

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Viktor/backend #41

wants to merge 18 commits into from

Conversation

zilopbg
Copy link

@zilopbg zilopbg commented Mar 31, 2024

This MR introduces the following changes:

  1. Upgrades gradle to 5.6.4, the sqlite library to 3.45.2 and sets the Java version to 11.
  2. Utilizes a simple DAO pattern to handle access to the different data sources.
  3. Adds the necessary logic to aggregate data (DefaultPopulationAggregator).
  4. Creates a class (DefaultCountryNameResolver) that should handle countries that exist under different names in the data-sources.
  5. Adopts log4j2 for logging.
  6. Adds unit tests.
  7. Aims to improve the code quality by introducing several packages, interfaces, etc. All classes receive the required dependencies through their constructors, so Spring could be adopted easily if/when needed.
  8. Creates a Solution.md file with instructions how to run the code.

Several TODOs are added in the code as points to discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant