EnvironmentChecker#virtualDisplayWorkingTest no longer fails if dispays are either disabled, or not of type virtual #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ays are either disabled, or not of type virtual
|
Not a very important point. |
|
As mentioned, my commit simply mimics already existing checks, so I did not want to introduce more change than necessary. If we can all agree on your proposal, then the changes should be applied to both sites. I, for one, also think that it would be more helpful to print the corresponding config-key directly. |
…yWorkingTest in EnvironmentChecker
|
I think it would be even better to directly name config-keys, as to help the user understand why the plugin behaves as it does; I made those changes. What do you think? |
|
LGTM |
|
Looking good, for future reference please refer to branch naming scheme in the contributing guidelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported that they've seen the warning log-entry, as printed by this environment-check, namely
even though they've disabled displays altogether, by setting
shop.display-itemsto false; this is undesired behavior. My commit simply mimics the checks as performed by it's line-relative predecessorvirtualDisplaySupportTest, as to pass if displays are disabled, or not of type virtual.