update verification migration with FK tags cascade delete

add required dependants to tags model add cascade delete test on tag spec
QutEcoacoustics · Feb 7, 2025 · ab0638a · ab0638a
1 parent 7b4bb01
commit ab0638a
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 9 deletions.
diff --git a/app/models/tag.rb b/app/models/tag.rb
@@ -30,10 +30,10 @@ class Tag < ApplicationRecord
   extend Enumerize
 
   # relations
-  has_many :taggings, inverse_of: :tag
+  has_many :taggings, inverse_of: :tag, dependent: :destroy
   has_many :audio_events, through: :taggings
   has_many :tag_groups, inverse_of: :tag
-  has_many :verifications, inverse_of: :tag
+  has_many :verifications, inverse_of: :tag, dependent: :destroy
 
   belongs_to :creator, class_name: 'User', inverse_of: :created_tags
   belongs_to :updater, class_name: 'User', inverse_of: :updated_tags, optional: true

diff --git a/app/models/verification.rb b/app/models/verification.rb
@@ -27,7 +27,7 @@
 #
 #  fk_rails_...  (audio_event_id => audio_events.id) ON DELETE => cascade
 #  fk_rails_...  (creator_id => users.id)
-#  fk_rails_...  (tag_id => tags.id)
+#  fk_rails_...  (tag_id => tags.id) ON DELETE => cascade
 #  fk_rails_...  (updater_id => users.id)
 #
 class Verification < ApplicationRecord

diff --git a/db/migrate/20250120064731_create_verifications.rb b/db/migrate/20250120064731_create_verifications.rb
@@ -6,7 +6,7 @@ def change
 
     create_table :verifications do |t|
       t.references :audio_event, null: false, foreign_key: { on_delete: :cascade }
-      t.references :tag, null: false, foreign_key: true
+      t.references :tag, null: false, foreign_key: { on_delete: :cascade }
       t.column :creator_id, :integer, null: false
       t.column :updater_id, :integer
       t.column :confirmed, :confirmation, null: false

diff --git a/db/structure.sql b/db/structure.sql
@@ -701,8 +701,8 @@ CREATE TABLE public.audio_events (
     channel integer,
     provenance_id integer,
     score numeric,
-    audio_event_import_file_id integer,
-    import_file_index integer
+    import_file_index integer,
+    audio_event_import_file_id bigint
 );
 
 
@@ -3940,7 +3940,7 @@ ALTER TABLE ONLY public.audio_recording_statistics
 --
 
 ALTER TABLE ONLY public.verifications
-    ADD CONSTRAINT fk_rails_77cbfa06a3 FOREIGN KEY (tag_id) REFERENCES public.tags(id);
+    ADD CONSTRAINT fk_rails_77cbfa06a3 FOREIGN KEY (tag_id) REFERENCES public.tags(id) ON DELETE CASCADE;
 
 
 --

diff --git a/spec/factories/verification_factory.rb b/spec/factories/verification_factory.rb
@@ -23,7 +23,7 @@
 #
 #  fk_rails_...  (audio_event_id => audio_events.id) ON DELETE => cascade
 #  fk_rails_...  (creator_id => users.id)
-#  fk_rails_...  (tag_id => tags.id)
+#  fk_rails_...  (tag_id => tags.id) ON DELETE => cascade
 #  fk_rails_...  (updater_id => users.id)
 #
 FactoryBot.define do

diff --git a/spec/models/tag_spec.rb b/spec/models/tag_spec.rb
@@ -145,4 +145,11 @@
     t.notes = { comment: 'testing' }
     expect(t).to be_valid
   end
+
+  it_behaves_like 'cascade deletes for', :tag, {
+    verifications: nil,
+    taggings: nil
+  } do
+    create_entire_hierarchy
+  end
 end
diff --git a/spec/models/verification_spec.rb b/spec/models/verification_spec.rb
@@ -23,7 +23,7 @@
 #
 #  fk_rails_...  (audio_event_id => audio_events.id) ON DELETE => cascade
 #  fk_rails_...  (creator_id => users.id)
-#  fk_rails_...  (tag_id => tags.id)
+#  fk_rails_...  (tag_id => tags.id) ON DELETE => cascade
 #  fk_rails_...  (updater_id => users.id)
 #
 describe Verification do