Skip to content
This repository has been archived by the owner on Jun 10, 2020. It is now read-only.

[WIP] add ability to convert original audio to flac for storage #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] add ability to convert original audio to flac for storage #50

wants to merge 2 commits into from

Conversation

cofiem
Copy link
Contributor

@cofiem cofiem commented Oct 30, 2016 •
edited by atruskie
Loading

Closes #36

@cofiem cofiem self-assigned this Oct 30, 2016
@atruskie
Copy link
Member

atruskie commented Oct 30, 2016 •
edited
Loading

I'm not quite sure of the scope of this PR...

  • there is only a unit test?
  • can we store:
  • Is there any option to enable these choices?
  • On which file is the HASH calculated? The source file or the FLAC result?
    • Perhaps it should be for both! Store the original file SHA-256 in the audio notes field
  • Is the FLAC encoding/decoding deterministic (it needs to be)?

The goal with #36 is to transcode all new audio into FLAC since storing WAV is untenable. I can't see how that is achieved with the current state of this PR?

@atruskie atruskie mentioned this pull request Oct 30, 2016
Open
@cofiem
Copy link
Contributor Author

cofiem commented Oct 30, 2016

Ah, I misunderstood. I thought this was just for supporting files originally in flac, not converting original files to flac for storage. This PR does not do that. That is a big change. I'll do that in this PR, so don't merge yet.

@cofiem cofiem changed the title add ability to storage original audio in flac [WIP] add ability to convert original audio to flac for storage Oct 30, 2016
@atruskie atruskie mentioned this pull request Oct 31, 2016
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@cofiem cofiem

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cofiem @atruskie