This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Bragi switch to alpine #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdrll
approved these changes
Jul 26, 2022
remi-dupre
reviewed
Jul 26, 2022
There was a problem hiding this comment.
As I understand it the goal of the migration to Alpine based images is to reduce image sizes?
In such a case it would be a nice move to use a builder image to compile binaries : Rust binaries don't require any runtime and we especially don't need the whole compile suite in the result image (which appears to take about 200MB).
|
Also, should we migrate the mimirsbrunn docker image to Alpine? |
The Sync was unnecessarily enforced which led to a breaking change with more recent version of csv_async.
remi-dupre
reviewed
Jul 28, 2022
remi-dupre
approved these changes
Aug 1, 2022
|
should we close it ? |
|
I think this is already used in production |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sec vulnerabilities improvements switch to alpine SO